-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: WPF workaround for importing extensions does not always work #201
Fixed: WPF workaround for importing extensions does not always work #201
Conversation
02dec26
to
533a735
Compare
The error does not seem to be related to my changes. Am I expected to do something with it? |
@clairernovotny any comments on this PR? |
Please rebase or bring in master and then I can merge |
Question: Have you tried the main .NET Core 3.1 SDK with the WindowsDesktop SDK an UseWpf set to true? Does that work? Curious as to why you need the extras for WPF currently? |
@clairernovotny it is for 1.6 branch and it is up to date with We use .NET Core build process for an old WPF project. For technical reasons the project can't switch to .NET Core completely (binaries must be loadable into .NET Framework process) but using .NET Core build tools allows to use newer NuGet, SDK-style project files with csproj-specified NuGet dependencies (rather than package.config) etc. |
I'm not planning on releasing any more 1.6 releases. What's keeping you on that old version? |
@clairernovotny sorry for the delayed response, I had to retry the upgrade. I remember I tried it back in January but completely forgot why decided to stay on the old branch. I'll update to the last version and rebase. |
The issue happens when BaseIntermediateOutputPath is overridden, thus MSBuildProjectExtensionsPath gets assigned without generated suffix even in *_wpftmp.*proj file. Since _SdkOriginalProjectExtensionsPath didn't have a fallback value - that prevented importing project extensions. This change adds the fallback, making it effectively like "if there's a suffix - remove it, otherwise use as is".
533a735
to
c37a5b9
Compare
@clairernovotny I hope you are well and healthy. I saw some related activity in WPF/NuGet repos but they don't look exactly promising yet. |
Thanks! :) |
The issue happens when BaseIntermediateOutputPath is overridden, thus
MSBuildProjectExtensionsPath gets assigned without generated suffix
even in *_wpftmp.*proj file.
Since _SdkOriginalProjectExtensionsPath didn't have a fallback value -
that prevented importing project extensions. This change adds the
fallback, making it effectively like "if there's a suffix - remove it,
otherwise use as is".