fix(#54): SubscriberApi.list() not returning credentials, field email…

… is missing in SubscriberDto (#55)
novuhq · Sep 13, 2023 · 5d67f52 · 5d67f52
1 parent b3dd86a
commit 5d67f52
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/novu/dto/subscriber.py b/novu/dto/subscriber.py
@@ -80,7 +80,7 @@ class SubscriberDto(CamelCaseDto["SubscriberDto"]):  # pylint: disable=R0902
     subscriber_id: str
     """Subscriber's ID"""
 
-    email: str
+    email: Optional[str] = None
     """Email of the subscriber"""
 
     first_name: Optional[str] = None

diff --git a/tests/api/test_subscriber.py b/tests/api/test_subscriber.py
@@ -31,14 +31,12 @@ def setUpClass(cls) -> None:
             "updatedAt": "2023-02-06T23:03:22.645Z",
             "__v": 0,
             "isOnline": False,
-            "email": "oscar.marie-taillefer@spikeelabs.fr",
             "lastOnlineAt": "2023-02-06T23:03:22.645Z",
         }
         cls.response_list = {"page": 0, "totalCount": 1, "pageSize": 10, "data": [cls.subscriber_json]}
         cls.response_get = {"data": cls.subscriber_json}
         cls.expected_dto = SubscriberDto(
             subscriber_id="63dafed4117f8c850991ec4a",
-            email="oscar.marie-taillefer@spikeelabs.fr",
             first_name=None,
             last_name=None,
             phone=None,