Skip to content

Commit

Permalink
feat(api): final sdk e2e changes
Browse files Browse the repository at this point in the history
  • Loading branch information
tatarco committed Dec 19, 2024
1 parent 16de0b5 commit 08aa7d0
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion apps/api/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</a>
</div>

# @novu/api
# @novu/api-service

A RESTful API for accessing the Novu platform, built using [NestJS](https://nestjs.com/).

Expand Down
4 changes: 2 additions & 2 deletions apps/api/jarvis-api-intro.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Hi, I'm Jarvis 🤖
I'm a bot built to help you with your contribution to Novu.
I will add instructions and guides on how to run the subset of the Novu platform associated to this issue and make your first contribution.

This issue was tagged as related to `@novu/api` and the related code is located at the `apps/api` folder, here is how I can help you:
This issue was tagged as related to `@novu/api-service` and the related code is located at the `apps/api` folder, here is how I can help you:

<details>
<summary>First time contributing to Novu?</summary>
Expand All @@ -17,7 +17,7 @@ If that's the first time you want to contribute to Novu here are a few simple st
</details>

<details>
<summary>Run and test `@novu/api` locally</summary>
<summary>Run and test `@novu/api-service` locally</summary>

### Run API in watch mode

Expand Down
1 change: 0 additions & 1 deletion eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ const noRestrictedImportsMultiLevelNovuPattern = {
group: [
'@novu/*/**/*',
'!@novu/api/**/*', // This allows all imports from @novu/api
// '!@novu/api/funcs/triggerBulk',
// These packages have legitimate exports 1 path part below the root level
// This flatMap logic ignores the path 1 below the root level and prevents deeper imports.
...['framework', 'js', 'novui'].flatMap((pkg) => [`!@novu/${pkg}/**/*`, `@novu/${pkg}/*/**/*`]),
Expand Down
2 changes: 1 addition & 1 deletion novu.code-workspace
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"path": ".",
},
{
"name": "🚀 @novu/api",
"name": "🚀 @novu/api-service",
"path": "apps/api",
},
{
Expand Down
2 changes: 1 addition & 1 deletion nx.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"groups": {
"apps": {
"projects": [
"@novu/api",
"@novu/api-service",
"@novu/dashboard",
"@novu/inbound-mail",
"@novu/web",
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
"release": "node scripts/release.mjs",
"release:version:apps": "nx release version --projects=tag:type:app",
"setup:project": "npx --yes pnpm@9.11.0 i && node scripts/setup-env-files.js && pnpm build",
"start:api:dev": "cross-env nx run @novu/api:start:dev",
"start:api:test": "cross-env nx run-many --target=start:test --projects=@novu/api",
"start:api": "cross-env nx run @novu/api:start",
"start:api:dev": "cross-env nx run @novu/api-service:start:dev",
"start:api:test": "cross-env nx run-many --target=start:test --projects=@novu/api-service",
"start:api": "cross-env nx run @novu/api-service:start",
"start:dal": "cross-env nx run @novu/dal:start",
"start:dashboard": "cross-env nx run @novu/dashboard:start",
"start:dev": "cross-env lerna run start:dev --stream --parallel --concurrency=20 --scope=@novu/{api,worker,web,widget,ws,notification-center}",
Expand Down

0 comments on commit 08aa7d0

Please sign in to comment.