Merge pull request #3992 from novuhq/fix-ci-action-run-backend

fix(ci): proper settings for secrets for run backend
novuhq · Aug 17, 2023 · 5a4162a · 5a4162a
2 parents 83d2c56 + 5805c06
commit 5a4162a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/.github/actions/run-backend/action.yml b/.github/actions/run-backend/action.yml
@@ -7,6 +7,12 @@ inputs:
     description: 'The Launch Darkly SDK key to use'
     required: false
     default: ''
+  cypress_github_oauth_client_id:
+    description: 'Cypress GitHub client ID'
+    required: true
+  cypress_github_oauth_client_secret:
+    description: 'Cypress GitHub client secret'
+    required: true
 
 runs:
   using: composite
@@ -15,8 +21,8 @@ runs:
     - name: Start API in TEST
       shell: bash
       env:
-        GITHUB_OAUTH_CLIENT_ID: ${{ secrets.CYPRESS_GITHUB_OAUTH_CLIENT_ID }}
-        GITHUB_OAUTH_CLIENT_SECRET: ${{ secrets.CYPRESS_GITHUB_OAUTH_CLIENT_SECRET }}
+        GITHUB_OAUTH_CLIENT_ID: ${{ inputs.cypress_github_oauth_client_id }}
+        GITHUB_OAUTH_CLIENT_SECRET: ${{ inputs.cypress_github_oauth_client_secret }}
         NODE_ENV: "test"
         PORT: "1336"
         TZ: "UTC"
@@ -26,6 +32,7 @@ runs:
       run: cd apps/api && pnpm start:build &
 
     - name: Start Worker
+      shell: bash
       env:
         NODE_ENV: "test"
         PORT: "1342"
@@ -35,4 +42,5 @@ runs:
       run: cd apps/worker && pnpm start:prod &
 
     - name: Wait on API and Worker
+      shell: bash
       run: wait-on --timeout=180000 http://localhost:1336/v1/health-check http://localhost:1342/v1/health-check
diff --git a/.github/workflows/reusable-web-e2e.yml b/.github/workflows/reusable-web-e2e.yml
@@ -70,6 +70,8 @@ jobs:
 
       - uses: ./.github/actions/run-backend
         with:
+          cypress_github_oauth_client_id: ${{ secrets.CYPRESS_GITHUB_OAUTH_CLIENT_ID }}
+          cypress_github_oauth_client_secret: ${{ secrets.CYPRESS_GITHUB_OAUTH_CLIENT_SECRET }}
           launch_darkly_sdk_key: ${{ secrets.LAUNCH_DARKLY_SDK_KEY }}
 
       - name: Start Client

diff --git a/.github/workflows/reusable-widget-e2e.yml b/.github/workflows/reusable-widget-e2e.yml
@@ -71,6 +71,8 @@ jobs:
 
       - uses: ./.github/actions/run-backend
         with:
+          cypress_github_oauth_client_id: ${{ secrets.CYPRESS_GITHUB_OAUTH_CLIENT_ID }}
+          cypress_github_oauth_client_secret: ${{ secrets.CYPRESS_GITHUB_OAUTH_CLIENT_SECRET }}
           launch_darkly_sdk_key: ${{ secrets.LAUNCH_DARKLY_SDK_KEY }}
 
       # Runs a single command using the runners shell