fix: remove code for pushpad broadcast notifications that are not use…

…d by novu
novuhq · Oct 13, 2023 · 5b53c0c · 5b53c0c
1 parent 192beb3
commit 5b53c0c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 21 deletions.
diff --git a/providers/pushpad/src/lib/pushpad.provider.spec.ts b/providers/pushpad/src/lib/pushpad.provider.spec.ts
@@ -7,13 +7,9 @@ test('should trigger pushpad library correctly', async () => {
   });
 
   const mockDeliverTo = jest.fn();
-  const mockBroadcast = jest.fn();
   const mockBuildNotification = jest
     .spyOn(provider, 'buildNotification' as any)
-    .mockReturnValue({
-      deliverTo: mockDeliverTo,
-      broadcast: mockBroadcast,
-    });
+    .mockReturnValue({ deliverTo: mockDeliverTo });
 
   const result = await provider.sendMessage({
     title: 'Test',
@@ -30,7 +26,6 @@ test('should trigger pushpad library correctly', async () => {
 
   expect(mockBuildNotification).toHaveBeenCalled();
   expect(mockDeliverTo).toHaveBeenCalledTimes(1);
-  expect(mockBroadcast).not.toHaveBeenCalled();
 
   expect(result).toHaveProperty('id');
   expect(result).toHaveProperty('date');

diff --git a/providers/pushpad/src/lib/pushpad.provider.ts b/providers/pushpad/src/lib/pushpad.provider.ts
@@ -31,21 +31,12 @@ export class PushpadPushProvider implements IPushProvider {
 
     let notificationId = null;
 
-    if (options.target) {
-      notification.deliverTo(options.target, function (err, result) {
-        if (err) {
-          throw Error(err);
-        }
-        notificationId = result.id;
-      });
-    } else {
-      notification.broadcast(function (err, result) {
-        if (err) {
-          throw Error(err);
-        }
-        notificationId = result.id;
-      });
-    }
+    notification.deliverTo(options.target, function (err, result) {
+      if (err) {
+        throw Error(err);
+      }
+      notificationId = result.id;
+    });
 
     return {
       id: notificationId,