Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NV-2601 - Add support in the client for tenant feature #3846

Conversation

djabarovgeorge
Copy link
Contributor

What change does this PR introduce?

Feature flag to hide Tenant functionality

Why was this change needed?

We introducing new Tenant functionality that needs to be hidden before the general auditory release. We are planning to roll out that functionality to some early birds before the GA release.

Definition of Done

  • A feature flag is created in Lanch Darkly
  • Created related feature flag hook

@linear
Copy link

linear bot commented Jul 24, 2023

NV-2601 Add support in the client for tenant feature

What?

Feature flag to hide Tenant functionality

Why? (Context)

We introducing new Tenant functionality that needs to be hidden before the general auditory release. We are planning to roll out that functionality to some early birds before the GA release.

Definition of Done

  • A feature flag is created in Lanch Darkly
  • Created related feature flag hook

@@ -68,3 +68,7 @@ export const IS_MULTI_PROVIDER_CONFIGURATION_ENABLED = isCypress
: window._env_.IS_MULTI_PROVIDER_CONFIGURATION_ENABLED ||
process.env.IS_MULTI_PROVIDER_CONFIGURATION_ENABLED ||
'false';

export const IS_MULTI_TENANCY_ENABLED = isCypress
? window._env_.IS_MULTI_TENANCY_ENABLED || process.env.IS_MULTI_TENANCY_ENABLED || 'true'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not sure if to call it multi-tenancy or just tenant/tenants, naming 🤦‍♂️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it sounds good

Copy link
Contributor

@ainouzgali ainouzgali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@djabarovgeorge djabarovgeorge changed the base branch from next to stacked-tenants-support July 25, 2023 09:16
@djabarovgeorge djabarovgeorge merged commit 19cfdd9 into stacked-tenants-support Jul 26, 2023
@djabarovgeorge djabarovgeorge deleted the NV-2601-add-support-in-the-client-for-tenant-feature branch July 26, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants