feat: add delete item and name fields for novu providers #3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsoderberg
commented
Jul 27, 2023
apps/web/src/pages/integrations/components/UpdateIntegrationCommonFields.tsx
Show resolved
Hide resolved
davidsoderberg
commented
Jul 27, 2023
| }: { | ||
| provider: IIntegratedProvider | null; | ||
| onSuccessDelete: () => void; | ||
| children?: ReactNode | null; |
There was a problem hiding this comment.
To be able to show the Free tag for Novu provider
davidsoderberg
commented
Jul 27, 2023
|
|
||
| <NovuProviderSidebarContent provider={selectedProvider} /> | ||
| </Sidebar> | ||
| <FormProvider {...methods}> |
There was a problem hiding this comment.
I keept adding stuff up here because I did not like to make the part lower down even more complex.
davidsoderberg
commented
Jul 27, 2023
| @@ -184,15 +197,15 @@ export function UpdateProviderSidebar({ | |||
| <Sidebar | |||
| isOpened={isSidebarOpened} | |||
| isLoading={areProvidersLoading || areEnvironmentsLoading} | |||
| isExpanded={sidebarState === 'expanded'} | |||
| isExpanded={sidebarState === SidebarStateEnum.EXPANDED} | |||
There was a problem hiding this comment.
And some small refactoring
Base automatically changed from
nv-2565-remove-usecase-getnovuintegration
to
nv-2503-store-novu-providers-email-sms-in-the-database
July 28, 2023 08:18
…the-list-of-providers-on-add feat: remove novu providers for select provider
djabarovgeorge
approved these changes
Jul 31, 2023
davidsoderberg
merged commit 85379f0
into
nv-2503-store-novu-providers-email-sms-in-the-database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Change to the normal update header for provider and add name + identifier fields.
Other information (Screenshots)