-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): set integration as primary and priority system #3873
feat(api): set integration as primary and priority system #3873
Conversation
…api-update-integrations-logic-for-primary-and-private-fields
…api-update-integrations-logic-for-primary-and-private-fields
…api-update-integrations-logic-for-primary-and-private-fields
…api-update-integrations-logic-for-primary-and-private-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great! :) I just had a couple of questions sorry about it, if my concerns are by design I can approve it just let me know
another small thing i think create and update usecase shares some logic maybe we could extract it as well but totally could we for future refactoring.
apps/api/src/app/integrations/usecases/create-integration/create-integration.usecase.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/integrations/usecases/create-integration/create-integration.usecase.ts
Show resolved
Hide resolved
apps/api/src/app/integrations/usecases/get-active-integration/get-active-integration.usecase.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/integrations/usecases/remove-integration/remove-integration.command.ts
Outdated
Show resolved
Hide resolved
libs/dal/src/repositories/integration/integration.repository.ts
Outdated
Show resolved
Hide resolved
libs/dal/src/repositories/integration/integration.repository.ts
Outdated
Show resolved
Hide resolved
...c/app/integrations/usecases/set-integration-as-primary/set-integration-as-primary.command.ts
Outdated
Show resolved
Hide resolved
...c/app/integrations/usecases/set-integration-as-primary/set-integration-as-primary.usecase.ts
Show resolved
Hide resolved
...c/app/integrations/usecases/set-integration-as-primary/set-integration-as-primary.usecase.ts
Show resolved
Hide resolved
apps/api/src/app/integrations/usecases/update-integration/update-integration.usecase.ts
Show resolved
Hide resolved
…api-update-integrations-logic-for-primary-and-private-fields
…api-update-integrations-logic-for-primary-and-private-fields
…api-update-integrations-logic-for-primary-and-private-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah looks great to me awesome work :)
What change does this PR introduce?
Set integration as "primary" endpoint and priority system logic:
Why was this change needed?
Other information (Screenshots)