Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: so swagger json validates #3969

Merged

Conversation

davidsoderberg
Copy link
Contributor

What change does this PR introduce?

Fix so swagger json is valid.

Other information (Screenshots)

Screenshot 2023-08-14 at 11 21 32

@linear
Copy link

linear bot commented Aug 14, 2023

NV-2653 Make sure our swagger json pass validation

What?

Add swagger api properties so swagger json pass validation on https://apitools.dev/swagger-parser/online

Screenshot_2023-08-01_at_11.33.11.png

Why? (Context)

Our docs will use the swagger json in the future see:

https://discord.com/channels/895029566685462578/1135882833055981659

Definition of Done

@github-actions github-actions bot added the CI/CD label Aug 14, 2023
@davidsoderberg davidsoderberg marked this pull request as ready for review August 14, 2023 11:15
Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@davidsoderberg davidsoderberg added this pull request to the merge queue Aug 15, 2023
Merged via the queue into next with commit 8b48525 Aug 15, 2023
@davidsoderberg davidsoderberg deleted the nv-2653-make-sure-our-swagger-json-pass-validation branch August 15, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants