feat(ci): separate the swagger validation in own runner plus improvement #3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
force-pushed
the
feat-create-reusable-actions
branch
from
449d2c6 to
9727dc7
Compare
davidsoderberg
approved these changes
Aug 16, 2023
p-fernandez
force-pushed
the
feat-create-reusable-actions
branch
from
9727dc7 to
5a0018d
Compare
p-fernandez
force-pushed
the
feat-create-reusable-actions
branch
from
5a0018d to
a987cb3
Compare
p-fernandez
commented
Aug 16, 2023
| name: Validate Swagger | ||
| runs-on: ubuntu-latest | ||
| needs: [get-affected] | ||
| if: ${{ fromJson(needs.get-affected.outputs.test-unit)[0] }} |
There was a problem hiding this comment.
We would expect to validate the Swagger when something affecting the unit tests for the API change.
p-fernandez
force-pushed
the
feat-create-reusable-actions
branch
from
a987cb3 to
cfd1829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Separates the Swagger validation in its own runner to avoid interfering in E2E test runners. Also isolates some reusable actions.
Why was this change needed?
Clarify the intention of the Swagger validation.
Other information (Screenshots)