Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variants polishing #4188

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Variants polishing #4188

merged 4 commits into from
Oct 2, 2023

Conversation

djabarovgeorge
Copy link
Contributor

What change does this PR introduce?

Why was this change needed?

Other information (Screenshots)

Copy link
Contributor

@ainouzgali ainouzgali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we have a way to make filters mandatory for variants already in the command level

@djabarovgeorge djabarovgeorge marked this pull request as ready for review October 1, 2023 18:41
@djabarovgeorge
Copy link
Contributor Author

I wonder if we have a way to make filters mandatory for variants already in the command level

It is a great idea but unfortunately, the scope of the request will be too big for this PR, in order to implement it we will need to do the following: Create a custom validation decorator, fix the nested validation that does not work at the moment, and the hardest part which will be to return the nested errors that we will get, therefore I will postpone it to another dedicated PR.

@djabarovgeorge
Copy link
Contributor Author

I wonder if we have a way to make filters mandatory for variants already in the command level

It is a great idea but unfortunately, the scope of the request will be too big for this PR, in order to implement it we will need to do the following: Create a custom validation decorator, fix the nested validation that does not work at the moment, and the hardest part which will be to return the nested errors that we will get, therefore I will postpone it to another dedicated PR.

Created #4306

@djabarovgeorge djabarovgeorge merged commit 8b99137 into variants-condition Oct 2, 2023
16 checks passed
@djabarovgeorge djabarovgeorge deleted the vatiants-polishing branch October 2, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants