feat: add abity to remove uploaded brand logo #4451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldziuba03
commented
Oct 6, 2023
| async function saveBrandsForm({ color, fontFamily, image }) { | ||
| const brandData = { | ||
| color, | ||
| logo: image, | ||
| logo: image || null, |
There was a problem hiding this comment.
"removed" image is an empty string, but backend has validation rule for strings to check if it's URL. This always fails.
logo is optional, so null will pass that validation rule and successfully remove the uploaded logo.
michaldziuba03
commented
Oct 6, 2023
| @@ -82,10 +88,12 @@ export function BrandingForm() { | |||
| setValue('image', path); | |||
| } | |||
|
|
|||
| const dropzoneRef = useRef<() => void>(null); | |||
There was a problem hiding this comment.
I created ref for Dropzone, because one of the buttons must trigger openning file explorer
michaldziuba03
commented
Oct 6, 2023
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| background-color: ${colors.BGDark + 'D6'}; |
There was a problem hiding this comment.
D6 is alpha channel for hex color constant.
michaldziuba03
commented
Oct 6, 2023
Comment on lines
+280
to
+286
| &:hover { | ||
| cursor: pointer; | ||
|
|
||
| ${DropzoneOverlay} { | ||
| display: flex; | ||
| } | ||
| } |
There was a problem hiding this comment.
show overlay on hover
scopsy
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
This PR introduces ability to remove uploaded brand logo
Why was this change needed?
Closes #3137
Other information (Screenshots)
Quick Loom video