chore: Updated Mocha to 10.2.0 #4536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
community
@novu/api
@novu/webhook
@novu/ws
providers
@novu/worker
@novu/inbound-mail
and removed
community
labels
scopsy
reviewed
Oct 16, 2023
providers/fcm/package.json
Outdated
| @@ -38,7 +38,7 @@ | |||
| "devDependencies": { | |||
| "@istanbuljs/nyc-config-typescript": "^1.0.1", | |||
| "@types/jest": "^29.5.0", | |||
| "@types/mocha": "^8.0.1", | |||
| "@types/mocha": "^10.0.2", | |||
There was a problem hiding this comment.
Seems like a tab issue here :)
There was a problem hiding this comment.
hey @scopsy , Corrected the tab issue
|
@ayushshukla7777 could you please update from next and re run pnpm install to resolve the conflicts there? |
|
Hey @scopsy , I have updated and pushed new commit as you said |
scopsy
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
chore: Update Mocha to the latest version - 10.2.0 and Updated @types/mocha to the latest version - 10.0.2
Why was this change needed?
closes #4527
Other information (Screenshots)