fix(infra): some pnpm workspace improv for dev flow #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopsy
reviewed
Oct 16, 2023
rifont
reviewed
Oct 16, 2023
p-fernandez
force-pushed
the
fix-pnpm-workspace
branch
from
baf57e8 to
f8a8637
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rifont
requested changes
Oct 18, 2023
rifont
approved these changes
Oct 18, 2023
|
cc. @djabarovgeorge |
I was mentioned because we are looking into splitting the pnpm workspace of the monorepo and the submodule into two separate workspaces. I am aware of the changes here, no matter what change is done here we will refactor them to fit the two separated workspaces. |
|
Ok, let's try then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
Other information (Screenshots)