style: update log message to better reflect context #4555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-3010 Unmatched job id in the message log and context.
What?Not sure if bug or by the design, we need to check if the jobId and the job id in the message should be the same here. Why? (Context)Consistency in the logs. Definition of Done |
scopsy
deleted the
nv-3010-unmatched-job-id-in-the-message-log-and-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
NV-3010
Update the log message to better reflect the next job scheduling to not confuse with the start of the processing of a job.
Why was this change needed?
This happens in the end of an existing job, while scheduling the next one. hence starting is a bit confusing
Other information (Screenshots)