Fix icon overlapping #4574
Merged
Fix icon overlapping #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for doing this, however the spacing between each icon should be equal. Currently the horizontal ellipse and the X icon does not have the same spacing as the rest. I would recommend using a flex box instead of just setting a margin. |
Cliftonz
suggested changes
Oct 18, 2023
|
Screenshot after these changes,
Now it look way better please check changes @Cliftonz |
|
That look great, thanks for the contribution! |
Cliftonz
approved these changes
Oct 19, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
This PR fixes the icons overlapping in Integration Store Test Providers Sidebar .
The change was in the CSS part, Initially margin property was applied on button but it was not working properly so my change fixed that problem.
Why was this change needed?
This change was needed because Icons overlapping do not look good and impact user experience.
Closes #4533
Other information (Screenshots)
Sharing Screenshots after changes
Before :
