Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added words for Kannada language translation and also changed the language code #4598

Merged
merged 5 commits into from
Oct 21, 2023

Conversation

Atharva1723
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It adds two more words for the translation to kannada and changes the actual language code for Kannada

Why was this change needed?
Because settings and no new notification words were not translated into Kannada
And the actual code for kannada language is kn not ka

@Atharva1723
Copy link
Contributor Author

Please review this PR ? @djabarovgeorge @davidsoderberg @scopsy

Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. 🌟

@Atharva1723
Copy link
Contributor Author

@p-fernandez thank you for approving the PR . Do you know why is the Web Cypress check failing ?

@p-fernandez
Copy link
Contributor

@p-fernandez thank you for approving the PR . Do you know why is the Web Cypress check failing ?

Flakey internal tests. I am checking anyway. Your changes shouldn't affect.

@Atharva1723
Copy link
Contributor Author

@p-fernandez thank you for approving the PR . Do you know why is the Web Cypress check failing ?

Flakey internal tests. I am checking anyway. Your changes shouldn't affect.

Okay, If any changes are required tell me accordingly

@Atharva1723
Copy link
Contributor Author

Still it is failing

@p-fernandez
Copy link
Contributor

Merging with the failing test as it is unrelated to the PR and seems to be related to Cypress and Webpack versions.
cypress-io/cypress#22682

@p-fernandez p-fernandez merged commit 5046d88 into novuhq:next Oct 21, 2023
19 of 20 checks passed
@Atharva1723
Copy link
Contributor Author

Can I create a typescript file for Georgian as that is not created before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants