-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added words for Kannada language translation and also changed the language code #4598
Conversation
Please review this PR ? @djabarovgeorge @davidsoderberg @scopsy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. 🌟
@p-fernandez thank you for approving the PR . Do you know why is the Web Cypress check failing ? |
Flakey internal tests. I am checking anyway. Your changes shouldn't affect. |
Okay, If any changes are required tell me accordingly |
Still it is failing |
Merging with the failing test as it is unrelated to the PR and seems to be related to Cypress and Webpack versions. |
Can I create a typescript file for Georgian as that is not created before |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It adds two more words for the translation to kannada and changes the actual language code for Kannada
Why was this change needed?
Because settings and no new notification words were not translated into Kannada
And the actual code for kannada language is kn not ka