fix(api): Cancel all jobs related to a transactionId from the 'cancel' method #4616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-3019 Cancel trigger api is not cancelling all events related to that transactionId
Checkout loom video below for steps to reproduce https://www.loom.com/share/11a83935b8714bbdbedb146040f4b058?sid=58dd374c-1a1a-42e1-91ce-f0377fcb5c75 |
scopsy
commented
Oct 22, 2023
| @@ -24,13 +24,13 @@ describe('Trigger event - Delay triggered events - /v1/events/trigger (POST)', f | |||
| let standardQueueService: StandardQueueService; | |||
| const messageRepository = new MessageRepository(); | |||
|
|
|||
| const triggerEvent = async (payload, transactionId?: string, overrides = {}) => { | |||
| const triggerEvent = async (payload, transactionId?: string, overrides = {}, to = [subscriber.subscriberId]) => { | |||
There was a problem hiding this comment.
Added the ability to test more than 1 subscriber
scopsy
commented
Oct 22, 2023
| @@ -342,7 +344,7 @@ describe('Trigger event - Delay triggered events - /v1/events/trigger (POST)', f | |||
| content: '', | |||
| metadata: { | |||
| unit: DigestUnitEnum.SECONDS, | |||
| amount: 0.1, | |||
| amount: 5, | |||
There was a problem hiding this comment.
To avoid flakiness in the test
ainouzgali
reviewed
Oct 22, 2023
Comment on lines
+10
to
+17
| const jobs = await this.jobRepository.find( | ||
| { | ||
| _environmentId: command.environmentId, | ||
| transactionId: command.transactionId, | ||
| status: JobStatusEnum.DELAYED, | ||
| }, | ||
| '_id' | ||
| ); |
There was a problem hiding this comment.
it will still find only the delay job - as its the only one that has DELAYED status. The others are pending. Or am I missing something?
There was a problem hiding this comment.
Never mind. Got you. its multiple subscribers
ainouzgali
approved these changes
Oct 22, 2023
scopsy
deleted the
nv-3019-cancel-trigger-api-is-not-cancelling-all-events-related-to
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
Closes NV-3019
Other information (Screenshots)