feat: added option to override html for emails #4894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
This change introduces the ability to override the html content for email messages.
Why was this change needed?
When you try to override the email text while triggering an event it simply has no effect since by default the email template defined in the workflow will always be used ( expect if the client does not support html rendering the overridden text will be displayed).
Also it will be good if the html template can be overridden so a single workflow can be used to send dynamic email content
Closes#4856https://github.com/novuhq/novu/issues/4856Other information (Screenshots)
Here is an example email received through overridden html email content