Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: senderName and subject override for email providers #4903

Merged
merged 6 commits into from
Nov 28, 2023
Merged

fix: senderName and subject override for email providers #4903

merged 6 commits into from
Nov 28, 2023

Conversation

jainpawan21
Copy link
Member

What change does this PR introduce?

  • Fix sendername and subject override bug
  • Add support of overridden sendername in those email providers which support separate field for sendername

Other information (Screenshots)

@linear Linear
Copy link

linear bot commented Nov 28, 2023

NV-3232 bug: sendername and subject override is not working with email

What?

Why? (Context)

Definition of Done

LetItRock
LetItRock approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 🔥

@jainpawan21 jainpawan21 merged commit 63f7fe8 into next Nov 28, 2023
26 checks passed
@jainpawan21 jainpawan21 deleted the NV-3232 branch November 28, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LetItRock LetItRock LetItRock approved these changes

Assignees
No one assigned
Labels
@novu/shared @novu/worker providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jainpawan21 @LetItRock