Refactor readiness service to receive indicator list #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
commented
Nov 28, 2023
| attempt: i, | ||
| message: `Some health indicator returned false when checking if queues are enabled ${i}/${retries}`, | ||
| }, | ||
| `Some health indicator returned false when checking if queues are enabled ${i}/${retries}`, |
There was a problem hiding this comment.
this is a small fix, looks like the new relic is not able to print messages of a warning log level, fixed it as a tmp solution.
djabarovgeorge
commented
Nov 28, 2023
Comment on lines
57
to
61
| const statuses = healths.map( | ||
| (health: HealthIndicatorResult) => Object.values(health)[0].status | ||
| ); | ||
|
|
||
| return healths.every((health) => !!health === true); | ||
| return statuses.every((status: HealthIndicatorStatus) => status === 'up'); |
There was a problem hiding this comment.
Created this explicit check of the status.
The old way works now because we throw exceptions if the status false, however, i would like to be explicit if possible.
…ing-the-service-instance-sw-health-indicator' into refactor-readiness-service-to-receive-indicator-list # Conflicts: # packages/application-generic/src/modules/queues.module.ts
…ing-the-service-instance-sw-health-indicator' into refactor-readiness-service-to-receive-indicator-list # Conflicts: # packages/application-generic/src/modules/queues.module.ts # packages/application-generic/src/services/readiness/readiness.service.ts
Base automatically changed from
nv-3202-race-condition-when-reading-the-service-instance-sw-health-indicator
to
next
December 4, 2023 14:34
LetItRock
approved these changes
Dec 5, 2023
djabarovgeorge
deleted the
refactor-readiness-service-to-receive-indicator-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
In this PR we readiness service to receive an indicator list, it is a preparation so we could add readiness to the WS app.
Why was this change needed?
In order to make readiness service more modular.
Other information (Screenshots)