Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Worker deploy queues matrix #4975

Merged
merged 13 commits into from
Dec 13, 2023
Merged

feat(ci): Worker deploy queues matrix #4975

merged 13 commits into from
Dec 13, 2023

Conversation

scopsy
Copy link
Contributor

@scopsy scopsy commented Dec 12, 2023

This deploys individual queues to the AWS services associated

Comment on lines +65 to +74
deploy_general_worker:
needs: build_dev_worker
uses: ./.github/workflows/reusable-app-service-deploy.yml
secrets: inherit
with:
environment: Development
service_name: worker
terraform_workspace: novu-dev
# This is a workaround to an issue with matrix outputs
docker_image: ghcr.io/novuhq/novu/worker-ee:${{ github.sha }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored to use the existing reusable component instead of a duplicate here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general worker is a temporary phase until we fully migrate

@@ -0,0 +1,103 @@
name: Deploy Workers Job
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a new resuable flow, due to the higher complexity of deploying the workers

deployments: write
strategy:
matrix:
worker: ${{fromJson(needs.infrastructure_data.outputs.services_to_deploy)}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This json is located in terraform and dynamically extracts all workers we have there

@scopsy scopsy merged commit 14cae4e into next Dec 13, 2023
18 of 19 checks passed
@scopsy scopsy deleted the worker-deploy-queues branch December 13, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant