fix(worker): timed digest event merging #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopsy
commented
Dec 13, 2023
|
|
||
| const promiseTimeout = (ms: number): Promise<void> => new Promise((resolve) => setTimeout(resolve, ms)); | ||
|
|
||
| describe('Trigger event - Scheduled Digest Mode - /v1/events/trigger (POST)', function () { |
There was a problem hiding this comment.
Added a new test suite for scheduled digest
scopsy
commented
Dec 13, 2023
| @@ -215,7 +216,7 @@ export class JobRepository extends BaseRepository<JobDBModel, JobEntity, Enforce | |||
| _subscriberId: this.convertStringToObjectId(job._subscriberId), | |||
| ...(digestKey && { [`payload.${digestKey}`]: digestValue }), | |||
| }, | |||
| '_id' | |||
| '_id _notificationId' | |||
There was a problem hiding this comment.
We removed the digest filter steps, and in order to replace it's functionality of updating the notificationId after the active digest, we return it here to later update the entity.
scopsy
commented
Dec 13, 2023
libs/testing/src/jobs.service.ts
Outdated
| } | ||
| } | ||
| }, | ||
| runDelayedImmediatly: async () => { |
There was a problem hiding this comment.
This new testing functionality allows running immediatly delayed jobs on bull mq
scopsy
commented
Dec 13, 2023
| $set: { | ||
| status: JobStatusEnum.MERGED, | ||
| _mergedDigestId: activeDigestId, | ||
| await Promise.all([ |
There was a problem hiding this comment.
Refactored to use promise all to improve performance
scopsy
commented
Dec 13, 2023
| public async execute( | ||
| command: DigestFilterStepsCommand | ||
| ): Promise<NotificationStepEntity[]> { | ||
| const action: DigestFilterStepsRegular | DigestFilterStepsTimed = |
There was a problem hiding this comment.
This code is not needed anymore, since we want to only make a single decision on digest merged or not in the digest add job phase. Instead of doing it multiple times.
scopsy
changed the title
LetItRock
force-pushed
the
nv-3288-digest-events-are-not-aggregated-in-scheduled-digest
branch
from
fab9752 to
882f781
Compare
LetItRock
deleted the
nv-3288-digest-events-are-not-aggregated-in-scheduled-digest
branch
LetItRock
added a commit
that referenced
this pull request
Dec 13, 2023
* fix: timed digest event gathering * feat: remove un needed digest filtering steps * fix: spelling * fix: object id typing * fix: increase timeout * chore(api): remove mocha timeout on package.json scripts --------- Co-authored-by: Paweł <pawel.tymczuk@gmail.com>
LetItRock
added a commit
that referenced
this pull request
Dec 13, 2023
* fix: timed digest event gathering * feat: remove un needed digest filtering steps * fix: spelling * fix: object id typing * fix: increase timeout * chore(api): remove mocha timeout on package.json scripts --------- Co-authored-by: Paweł <pawel.tymczuk@gmail.com>
LetItRock
added a commit
that referenced
this pull request
Dec 13, 2023
hotfix: timed digest event merging (#4979)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
NV-3288
Other information (Screenshots)