fix: isend sms provider unexpected provider error #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for dev-web-novu failed.
|
github-actions
bot
added
@novu/api
@novu/web
@novu/dal
@novu/shared
providers
@novu/worker
labels
BiswaViraj
reviewed
Jan 31, 2024
package.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "commit": "cz", | |||
| "nx": "nx", | |||
| "lint-staged": "lint-staged", | |||
| "generate:provider": "npx hygen provider new --version 0.16.3", | |||
| "generate:provider": "npx hygen provider new --version 0.22.0", | |||
There was a problem hiding this comment.
Nice 👌🏼
But I am wondering if there is a way we can automate this version number.
There was a problem hiding this comment.
Not sure how to read version in package.json 🙂
There was a problem hiding this comment.
Let's create a linear ticket for that and address it later
There was a problem hiding this comment.
BiswaViraj
reviewed
Feb 2, 2024
Added ✅ |
BiswaViraj
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
closes #5123
Other information (Screenshots)