Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv 2995 reusable email preview component #5143

Conversation

BiswaViraj
Copy link
Member

What change does this PR introduce?

  • email preview

Why was this change needed?

Other information (Screenshots)

Copy link

linear bot commented Feb 1, 2024

Base automatically changed from nv-3007-create-the-channel-preview-sidebar-and-route to translation-management-beta February 4, 2024 14:58
@BiswaViraj BiswaViraj marked this pull request as ready for review February 5, 2024 07:14
@BiswaViraj BiswaViraj force-pushed the nv-2995-reusable-email-preview-component branch from 1c6b192 to c3cb3b0 Compare February 5, 2024 07:15
@BiswaViraj BiswaViraj requested a review from ainouzgali February 5, 2024 07:15
Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left you a few suggestions ;)

Also when a new step is created and there are no locales used in the template, there is no need I guess to show an empty dropdown, the same if we have just one locale.

Screenshot 2024-02-05 at 17 31 55

Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@BiswaViraj BiswaViraj merged commit 729c99e into translation-management-beta Feb 9, 2024
23 checks passed
@BiswaViraj BiswaViraj deleted the nv-2995-reusable-email-preview-component branch February 9, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants