Create a script to increase the amount of storage space on default runner #5262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new 'subscribers' field to the WebhookResponseDto and subsequently updated the convertToDTO function in the 'convert-response.usecase.ts' file to include this field. Additionally, updated the 'execute' method in 'get-webhook.usecase.ts' to return a Promise of 'WebhookResponseDto' type or null. Also, the method 'triggerWebhook' in 'webhook.controller.ts' has been significantly updated to handle webhook triggers more robustly.
The 'free-space' action in GitHub workflow has been updated to stop purging web browser packages - firefox, google-chrome-stable, and microsoft-edge-stable. This ensures these resources get retained after the action execution allowing for browser-based operations or tests in the workflow.
An 'apt clean' command is added in 'free-space' action of the GitHub workflow. This is to ensure we free up the apt cache and potentially reclaim space that can be used for more crucial processes or resources during the execution of workflow actions.
❌ Deploy Preview for dev-web-novu failed.
|
AliaksandrRyzhou
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
LGTM. I've added cspell new words. Do we have to add the same step to the production build? As I remember currently Gali faces this issue only with API service or we have to take care about other services too. How do you think? Anyway we can merge it and see as it goes on
|
@Cliftonz @AliaksandrRyzhou I see that we haven't tested this on all test.yml pipelines. https://github.com/novuhq/novu/actions/runs/8172265709/job/22342316168?pr=5253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a script to the parts of the pipeline that do the docker build.
This script is a temporary fix by removing unused and preinstalled tooling and removes apt caches.