Unhandled Error: SyntaxError JSON.parse(<anonymous>) #5303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
approved these changes
Mar 14, 2024
ainouzgali
merged commit aeaf2a6
into
nv-3550-translation-with-params-not-included-in-payload-generation
19 checks passed
ainouzgali
deleted the
nv-3548-unhandled-error-syntaxerror-jsonparseanonymous
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Catch the parsing error for invalid json input on the variables assignment.
I decided to return an empty payload so it will be more pronounced for the user that the preview shown is without his variable assignments.
Why was this change needed?
Other information (Screenshots)