feat(dal): add deleted index and type safety index #5309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
commented
Mar 17, 2024
Comment on lines
+185
to
+186
| function index(fields: IndexDefinition<SubscriberEntity>, options?: IndexOptions) { | ||
| subscriberSchema.index(fields, options); |
There was a problem hiding this comment.
@rifont How about such an approach? while developing I noticed we don't have our indexes typed, meaning we can do indexed typos.
Doing this as a POC, I tried to make it a bit more generic but TS gave me problems :/
There was a problem hiding this comment.
mongoose is so poor when it comes to the types... yes the problems might be because we force some fields...
I like this approach 🙌
There was a problem hiding this comment.
I like it too, let's revisit generic typings as part of a holistic approach to strongly typing Mongoose. Ship it 🚀
LetItRock
approved these changes
Mar 18, 2024
Comment on lines
+185
to
+186
| function index(fields: IndexDefinition<SubscriberEntity>, options?: IndexOptions) { | ||
| subscriberSchema.index(fields, options); |
There was a problem hiding this comment.
mongoose is so poor when it comes to the types... yes the problems might be because we force some fields...
I like this approach 🙌
rifont
approved these changes
Mar 18, 2024
LetItRock
merged commit d504201
into
nv-3567-subscribers-are-duplicated-during-the-burst-of-events
27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
We want to optimize the call checking for non deleted subscribers.
This change is recommended by Mongodb Atlas.
As an alternative, the query may need to be changed.
Why was this change needed?
This will increase the query speed of calls looking for non deleted subscribers and will increase the trigger speed.
Other information (Screenshots)