-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ringcentral provider #536
Ringcentral provider #536
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! But unfortunately we can't use dotenv for passing the environment variables since we need to pass them during runtime inside the API
providers/ringcentral/README.md
Outdated
## Usage | ||
|
||
```javascript | ||
FILL IN THE INITIALIZATION USAGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please provide the example here :)
from: string; | ||
} | ||
) { | ||
this.rcsdk = new RingCentralSDK({ server: process.env.RC_SERVER_URL, clientSecret: process.env.RC_CLIENT_SECRET, clientId: process.env.RC_CLIENT_ID }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortatently we can't use env variables to those params, they should be passed in the constructor since we need to change it dynamically during runtime
@ninjadev101 do you need any help to complete this one or is anything unclear that we could help you with? |
@davidsoderberg I can't complete this one because Ringcentral does not accept developer account creation at this time. And their sdk needs some environmental variables which need to be set. @scopsy said we can pass through constructor params but I am worried if that breaks our provider rules... |
@ninjadev101, I found this link https://developers.ringcentral.com/ have you tried create an account here? Because we where able to get credentials from it :) |
[NV-181] - Add Ringcentral sms provider #77
Not tested...