-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): Add feature flag for Hubspot onboarding flow #5387
Conversation
Several updates have been performed in the pnpm-lock.yaml. This involves version upgrades for a range of dependencies including '@opentelemetry/exporter-trace-otlp-http', '@opentelemetry/core', and '@opentelemetry/otlp-transformer'. Also '@opentelemetry/semantic-conventions' version was changed from 1.19.0 to 1.22.0 across multiple dependencies.
Added the terms "OTLP" and "otlp" to the cspell.json dictionary. This inclusion will extend the spell check functionality and ensure the correct use of these terms across the codebase.
The 'service.version' has been commented out in the initialization of 'initializeOtelSdk' function. The current implementation required a manual update to the version. The plan is now to find a way to dynamically pass the version through environment variables or through the service itself.
The registration of the TracingModule now also includes a version input parameter, allowing for dynamic passing of service version details. The service version has been utilized in calls to 'initializeOtelSdk' within the TracingModule and TracingService files, enabling the provision of more specific service information in tracing operations.
# Conflicts: # .cspell.json # apps/api/src/app.module.ts # apps/webhook/src/app.module.ts # apps/ws/src/app.module.ts
The tracing module in the application-generic package has been simplified by removing a specific instrumentation for '@opentelemetry/instrumentation-pino'. This change results in the usage of a more generic getNodeAutoInstrumentations function call, which provides broader usage capabilities without the need for specific instrumentation.
Updated utm fields throughout the app
* feat: add messages new api * fix: spell * fix: controller
Co-authored-by: Richard Fontein <32132657+rifont@users.noreply.github.com>
Co-authored-by: Richard Fontein <32132657+rifont@users.noreply.github.com>
Co-authored-by: Richard Fontein <32132657+rifont@users.noreply.github.com>
Co-authored-by: Richard Fontein <32132657+rifont@users.noreply.github.com>
Co-authored-by: Richard Fontein <32132657+rifont@users.noreply.github.com>
Added unknown words
…e-blueprint-on-cross-origin' into nv-3188-incorrect-creation-of-the-blueprint-on-cross-origin
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dima Grossman <dima@grossman.io>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix: free trial banner * fix: so default value in cypress tests are string value true so parse function handles it correctly * feat: add feature flag check for free trial widget * fix: after pr comment
chore: Remove unused dependencies
This reverts commit fb1d640.
Revert "chore: Remove unused dependencies"
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What change does this PR introduce?
See #5386
Why was this change needed?
See #5386
Other information (Screenshots)
See #5386