Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Add feature flag for Hubspot onboarding flow #5387

Closed
wants to merge 152 commits into from

Conversation

rifont
Copy link
Collaborator

@rifont rifont commented Apr 9, 2024

What change does this PR introduce?

See #5386

Why was this change needed?

See #5386

Other information (Screenshots)

See #5386

Cliftonz and others added 30 commits March 7, 2024 19:45
Several updates have been performed in the pnpm-lock.yaml. This involves version upgrades for a range of dependencies including '@opentelemetry/exporter-trace-otlp-http', '@opentelemetry/core', and '@opentelemetry/otlp-transformer'. Also '@opentelemetry/semantic-conventions' version was changed from 1.19.0 to 1.22.0 across multiple dependencies.
Added the terms "OTLP" and "otlp" to the cspell.json dictionary. This inclusion will extend the spell check functionality and ensure the correct use of these terms across the codebase.
The 'service.version' has been commented out in the initialization of 'initializeOtelSdk' function. The current implementation required a manual update to the version. The plan is now to find a way to dynamically pass the version through environment variables or through the service itself.
The registration of the TracingModule now also includes a version input parameter, allowing for dynamic passing of service version details. The service version has been utilized in calls to 'initializeOtelSdk' within the TracingModule and TracingService files, enabling the provision of more specific service information in tracing operations.
# Conflicts:
#	.cspell.json
#	apps/api/src/app.module.ts
#	apps/webhook/src/app.module.ts
#	apps/ws/src/app.module.ts
The tracing module in the application-generic package has been simplified by removing a specific instrumentation for '@opentelemetry/instrumentation-pino'. This change results in the usage of a more generic getNodeAutoInstrumentations function call, which provides broader usage capabilities without the need for specific instrumentation.
Updated utm fields throughout the app
* feat: add messages new api

* fix: spell

* fix: controller
Co-authored-by: Richard Fontein <32132657+rifont@users.noreply.github.com>
Co-authored-by: Richard Fontein <32132657+rifont@users.noreply.github.com>
Co-authored-by: Richard Fontein <32132657+rifont@users.noreply.github.com>
Co-authored-by: Richard Fontein <32132657+rifont@users.noreply.github.com>
Co-authored-by: Richard Fontein <32132657+rifont@users.noreply.github.com>
Added unknown words
…e-blueprint-on-cross-origin' into nv-3188-incorrect-creation-of-the-blueprint-on-cross-origin
FlacorLopes and others added 11 commits April 7, 2024 15:59
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dima Grossman <dima@grossman.io>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix: free trial banner

* fix: so default value in cypress tests are string value true so parse function handles it correctly

* feat: add feature flag check for free trial widget

* fix: after pr comment
Revert "chore: Remove unused dependencies"
Copy link
Contributor

coderabbitai bot commented Apr 9, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit bdda3a8
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/66157adbb378ab00088e3b07
😎 Deploy Preview https://deploy-preview-5387--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rifont rifont deleted the fix-hs-onboarding-flow branch November 7, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment