-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): Minor UI fix in billing plans #6665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
force-pushed
the
minor_ui_fix_in_billing
branch
from
October 16, 2024 13:55
19ac9fb
to
fb0923a
Compare
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 13:55 — with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 13:55 — with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 13:55 — with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 13:59 — with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 13:59 — with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 13:59 — with
GitHub Actions
Inactive
SokratisVidros
force-pushed
the
minor_ui_fix_in_billing
branch
from
October 16, 2024 14:20
f8f8609
to
e8f7827
Compare
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 14:20 — with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 14:20 — with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 14:20 — with
GitHub Actions
Inactive
SokratisVidros
commented
Oct 16, 2024
@@ -60,7 +60,6 @@ type Feature = { | |||
const features: Feature[] = [ | |||
{ | |||
label: 'Platform', | |||
isContrast: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was refactored so that we never have to adjacent background colors that are the same.
ChmaraX
approved these changes
Oct 16, 2024
rifont
approved these changes
Oct 16, 2024
ChmaraX
approved these changes
Oct 16, 2024
SokratisVidros
force-pushed
the
minor_ui_fix_in_billing
branch
from
October 16, 2024 14:27
e8f7827
to
2f38a21
Compare
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 14:27 — with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 14:27 — with
GitHub Actions
Inactive
SokratisVidros
had a problem deploying
to
Linting
October 16, 2024 14:27 — with
GitHub Actions
Error
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 14:34 — with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 14:34 — with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 14:34 — with
GitHub Actions
Inactive
BiswaViraj
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer