Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Log exception traits #6685

Merged
merged 5 commits into from
Oct 14, 2024
Merged

fix(api): Log exception traits #6685

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2163223
fix(api): log stack trace in exception handler
rifont Oct 14, 2024
c38eded
refactor(api): improve error logging structure
rifont Oct 14, 2024
697a65b
refactor(exception-filter): simplify error logging
rifont Oct 14, 2024
8597db2
style: Update comment for New Relic logging key
rifont Oct 14, 2024
9e3bc2f
docs(exception-filter): update comment for logging key usage
rifont Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion apps/api/src/exception-filter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,20 @@ export class AllExceptionsFilter implements ExceptionFilter {
}
) {
const uuid = this.getUuid(exception);
this.logger.error({ exception, errorId: uuid }, `unexpected exception thrown`, 'Exception');
this.logger.error(
{
errorId: uuid,
/**
* It's important to use `err` as the key, pino (the logger we use) will
* log an empty object if the key is not `err`
*
* @see https://github.com/pinojs/pino/issues/819#issuecomment-611995074
*/
err: exception,
},
`Unexpected exception thrown`,
'Exception'
);

return { ...responseBody, errorId: uuid };
}
Expand Down
Loading