Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): get subscriber preference parameter swagger value #6696

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

jainpawan21
Copy link
Member

What changed? Why was the change needed?

Replace TriggerRecipientsTypeEnum with PreferenceLevelEnum

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 71dd779
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/670ec0415b59fd0008ae68f4
😎 Deploy Preview https://deploy-preview-6696--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jainpawan21 jainpawan21 changed the title fix: get subscriber preference parameter swagger value fix(api): get subscriber preference parameter swagger value Oct 15, 2024
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 52080c4
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/6715564265baf60008192a72
😎 Deploy Preview https://deploy-preview-6696--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jainpawan21 jainpawan21 requested a review from tatarco October 20, 2024 19:12
required: true,
description: 'the preferences level to be retrieved( Subscriber / Topic) ',
description: 'the preferences level to be retrieved (template / global) ',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the parentheses mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid values can be template or global

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'the preferences level to be retrieved (template / global) ',
description: 'Retrieve global or workflow level subscriber preferences',

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix this in next PR, this PR got auto merged after approval

required: true,
description: 'the preferences level to be retrieved( Subscriber / Topic) ',
description: 'the preferences level to be retrieved (template / global) ',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'the preferences level to be retrieved (template / global) ',
description: 'Retrieve global or workflow level subscriber preferences',

@jainpawan21 jainpawan21 merged commit 991a1da into next Oct 23, 2024
28 checks passed
@jainpawan21 jainpawan21 deleted the fix/get-subscriber-preferences-parameter-value branch October 23, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants