Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework): CJS/ESM for framework #6707

Merged
merged 11 commits into from
Oct 23, 2024
Merged

feat(framework): CJS/ESM for framework #6707

merged 11 commits into from
Oct 23, 2024

Conversation

SokratisVidros
Copy link
Contributor

@SokratisVidros SokratisVidros commented Oct 16, 2024

What changed? Why was the change needed?

Maximize compatibility with Node, TS and bundlers by supporting both ESM + CJS.

Report from attw

Screenshot 2024-10-16 at 19 03 45

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit dbd68af
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/6718ab631be84b0008642e96
😎 Deploy Preview https://deploy-preview-6707--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 16, 2024

Open in Stackblitz

@novu/client

pnpm add https://pkg.pr.new/novuhq/novu/@novu/client@6707

@novu/framework

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6707

@novu/headless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/headless@6707

@novu/nest

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nest@6707

@novu/js

pnpm add https://pkg.pr.new/novuhq/novu/@novu/js@6707

@novu/nextjs

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nextjs@6707

@novu/node

pnpm add https://pkg.pr.new/novuhq/novu/@novu/node@6707

@novu/notification-center

pnpm add https://pkg.pr.new/novuhq/novu/@novu/notification-center@6707

@novu/providers

pnpm add https://pkg.pr.new/novuhq/novu/@novu/providers@6707

novu

pnpm add https://pkg.pr.new/novuhq/novu@6707

@novu/react

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react@6707

@novu/react-native

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react-native@6707

@novu/shared

pnpm add https://pkg.pr.new/novuhq/novu/@novu/shared@6707

@novu/stateless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/stateless@6707

commit: cac8647

Copy link
Contributor

@rifont rifont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant ✨

Ship it! 🚀

@SokratisVidros SokratisVidros merged commit c51ed8f into next Oct 23, 2024
40 of 41 checks passed
@SokratisVidros SokratisVidros deleted the cjs_for_framework branch October 23, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants