-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(framework): CJS/ESM for framework #6707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 16:12
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 16:12
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 16:12
— with
GitHub Actions
Inactive
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
force-pushed
the
cjs_for_framework
branch
from
October 16, 2024 21:34
d992a6d
to
9852a39
Compare
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 21:34
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 21:34
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 16, 2024 21:34
— with
GitHub Actions
Inactive
@novu/client
@novu/framework
@novu/headless
@novu/nest
@novu/js
@novu/nextjs
@novu/node
@novu/notification-center
@novu/providers
novu
@novu/react
@novu/react-native
@novu/shared
@novu/stateless
commit: |
SokratisVidros
force-pushed
the
cjs_for_framework
branch
from
October 17, 2024 21:09
9852a39
to
dd9d511
Compare
SokratisVidros
temporarily deployed
to
Linting
October 17, 2024 21:09
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 17, 2024 21:09
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 17, 2024 21:09
— with
GitHub Actions
Inactive
SokratisVidros
force-pushed
the
cjs_for_framework
branch
from
October 17, 2024 21:24
dd9d511
to
d9cfbde
Compare
SokratisVidros
had a problem deploying
to
Linting
October 17, 2024 21:25
— with
GitHub Actions
Failure
SokratisVidros
temporarily deployed
to
Linting
October 17, 2024 21:25
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 17, 2024 21:25
— with
GitHub Actions
Inactive
SokratisVidros
force-pushed
the
cjs_for_framework
branch
from
October 17, 2024 21:27
d9cfbde
to
6cc4419
Compare
SokratisVidros
temporarily deployed
to
Linting
October 17, 2024 21:28
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 17, 2024 21:28
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 17, 2024 21:28
— with
GitHub Actions
Inactive
SokratisVidros
force-pushed
the
cjs_for_framework
branch
from
October 19, 2024 13:57
6cc4419
to
6d521a4
Compare
SokratisVidros
temporarily deployed
to
Linting
October 19, 2024 13:57
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 19, 2024 13:57
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 19, 2024 13:57
— with
GitHub Actions
Inactive
SokratisVidros
force-pushed
the
cjs_for_framework
branch
from
October 23, 2024 07:34
3c71477
to
e6d9e79
Compare
SokratisVidros
temporarily deployed
to
Linting
October 23, 2024 07:34
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 23, 2024 07:34
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 23, 2024 07:34
— with
GitHub Actions
Inactive
rifont
reviewed
Oct 23, 2024
rifont
reviewed
Oct 23, 2024
rifont
reviewed
Oct 23, 2024
rifont
reviewed
Oct 23, 2024
rifont
reviewed
Oct 23, 2024
rifont
reviewed
Oct 23, 2024
rifont
reviewed
Oct 23, 2024
rifont
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant ✨
Ship it! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Maximize compatibility with Node, TS and bundlers by supporting both ESM + CJS.
Report from
attw