Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): handle v1 legacy workflows redirect #6734

Conversation

BiswaViraj
Copy link
Member

What changed? Why was the change needed?

  • redirect to legacy editor for v1 workflows

Screenshots

Screen.Recording.2024-10-21.at.6.23.06.PM.mov
Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

linear bot commented Oct 21, 2024

Comment on lines +178 to +182
<Link to={workflowLink} reloadDocument={isV1Workflow}>
<TruncatedText className="cursor-pointer" text={workflow.name} />
</Link>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrapped it with Link to have url contexts and better UX

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: Awesome!!‏

@BiswaViraj BiswaViraj requested a review from rifont October 21, 2024 13:45
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit c981ee5
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/6718bf301be84b0008d7de22
😎 Deploy Preview https://deploy-preview-6734--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@rifont rifont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@BiswaViraj BiswaViraj force-pushed the nv-4474-handle-v1-workflows-by-redirecting-to-old-web-dashboard branch from eedec10 to c981ee5 Compare October 23, 2024 09:17
@BiswaViraj BiswaViraj merged commit 7c9743e into next Oct 23, 2024
27 checks passed
@BiswaViraj BiswaViraj deleted the nv-4474-handle-v1-workflows-by-redirecting-to-old-web-dashboard branch October 23, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants