Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(framework): Experiement with importing json-schema-faker #6762

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix(framework): Experiement with importing json-schema-faker #6762

merged 2 commits into from
Oct 24, 2024

Conversation

SokratisVidros
Copy link
Contributor

@SokratisVidros SokratisVidros commented Oct 23, 2024 •
edited
Loading

What changed? Why was the change needed?

This dependency is causing issues when @novu/framework is used in Next.js while webpack is trying to load it via ESM.

See here and here.

@SokratisVidros
fix(framework): Experiement with importing json-schema-faker
8a96a3d 
This dependency is causing issues when @novu/framework is used in Next.js while webpack is trying to load it via ESM.
@netlify Netlify
Copy link

netlify bot commented Oct 23, 2024 •
edited
Loading

✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit acc8229
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/6719fa62bc9f250008d85d8c
😎 Deploy Preview https://deploy-preview-6762--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rifont
rifont approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@rifont rifont left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great detective work. Let's add some code comments referencing the outstanding GH issues, mentioning both:

  • not to use the default export with json-schema-faker
  • not to use import keyword with json-schema-faker

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 24, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6762

commit: acc8229

@SokratisVidros SokratisVidros marked this pull request as ready for review October 24, 2024 07:44
@SokratisVidros SokratisVidros merged commit af72058 into next Oct 24, 2024
35 of 37 checks passed
@SokratisVidros SokratisVidros deleted the fix_esm_issues_for_framework branch October 24, 2024 07:45
@github-actions github-actions bot mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifont rifont rifont approved these changes

@djabarovgeorge djabarovgeorge Awaiting requested review from djabarovgeorge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SokratisVidros @rifont