fix(api): get step data #6855
Merged
fix(api): get step data #6855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
commented
Nov 5, 2024
|
|
||
| private async findSteps(command: GetStepDataCommand, workflow: NotificationTemplateEntity) { | ||
| const currentStep = workflow.steps.find( | ||
| (stepItem) => stepItem._id === command.stepId || stepItem.stepId === command.stepId |
There was a problem hiding this comment.
the issue we had
we were missing find by stepId
djabarovgeorge
commented
Nov 5, 2024
| const controlValuesEntity = await this.controlValuesRepository.findOne({ | ||
| _environmentId: command.user.environmentId, | ||
| _organizationId: command.user.organizationId, | ||
| _workflowId: workflowId, |
There was a problem hiding this comment.
the issue we had
we were fetching by identifier before
LetItRock
approved these changes
Nov 5, 2024
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
approved these changes
Nov 5, 2024
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer