refactor(worker): Remove redundant Bridge error handling #6875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rifont
commented
Nov 6, 2024
apps/worker/src/app/workflow/usecases/execute-bridge-job/execute-bridge-job.usecase.ts
Show resolved
Hide resolved
rifont
commented
Nov 6, 2024
libs/application-generic/src/usecases/create-execution-details/types/index.ts
Show resolved
Hide resolved
libs/application-generic/src/usecases/execute-bridge-request/execute-bridge-request.usecase.ts
Show resolved
Hide resolved
rifont
commented
Nov 7, 2024
libs/application-generic/src/usecases/execute-bridge-request/execute-bridge-request.usecase.ts
Outdated
Show resolved
Hide resolved
…xecute-bridge-request.usecase.ts
SokratisVidros
approved these changes
Nov 7, 2024
rifont
commented
Nov 13, 2024
| }); | ||
|
|
||
| let raw = JSON.parse(executionDetailsRequired[0]?.raw ?? ''); | ||
| let error = raw.raw.data[0].message; | ||
| let error = raw.data[0].message; |
There was a problem hiding this comment.
This raw.raw stutter was unnecessary and made the UI more difficult to read.
rifont
commented
Nov 13, 2024
| @@ -38,64 +38,68 @@ export const isRegularDigestOutput = ( | |||
|
|
|||
| export const BRIDGE_EXECUTION_ERROR = { | |||
| INVALID_BRIDGE_URL: { | |||
| code: 'INVALID_BRIDGE_URL', | |||
| code: 'InvalidBridgeUrl', | |||
There was a problem hiding this comment.
It's easier to read a pascal-cased code on the UI, plus Framework uses PascalCase for all the error codes already and we should be consistent.
rifont
commented
Nov 13, 2024
| code: 'UnknownBridgeNonRequestError', | ||
| message: (url: string) => | ||
| `Unknown bridge non-request error calling \`${url}\``, | ||
| }, |
There was a problem hiding this comment.
Making sure that unknown cases also have an error code to refer to.
rifont
commented
Nov 13, 2024
| hooks: { | ||
| afterResponse: | ||
| command.afterResponse !== undefined ? [command.afterResponse] : [], | ||
| }, |
There was a problem hiding this comment.
A step to move away from depending on the got interface for errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
calculatedDelaycomputation to respectgotneeds to review thecomputedValue, ensuring that the retriable status codes and error codes are respectedafterResponsehookScreenshots
No retries for
400error, execution logs now shows only 1 entryNo retries for
408error, execution logs now shows only 1 entryNo retries for
502error, execution logs now shows only 1 entryExpand for optional sections
Related enterprise PR
Special notes for your reviewer