Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Nv 4516 in app step editor custom step controls form #6900

Merged

Conversation

BiswaViraj
Copy link
Member

@BiswaViraj BiswaViraj commented Nov 8, 2024

What changed? Why was the change needed?

Ready for Review ✅

Screenshots

Screen.Recording.2024-11-08.at.4.19.13.PM.mov
Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

linear bot commented Nov 8, 2024

Comment on lines +126 to +127
} else if (type === 'boolean') {
zodValue = z.boolean(isRequired ? { message: `${capitalize(key)} is required` } : undefined);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added boolean support

Copy link

pkg-pr-new bot commented Nov 8, 2024

Open in Stackblitz

@novu/client

pnpm add https://pkg.pr.new/novuhq/novu/@novu/client@6900

@novu/framework

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6900

@novu/headless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/headless@6900

@novu/nest

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nest@6900

@novu/js

pnpm add https://pkg.pr.new/novuhq/novu/@novu/js@6900

@novu/nextjs

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nextjs@6900

@novu/node

pnpm add https://pkg.pr.new/novuhq/novu/@novu/node@6900

@novu/notification-center

pnpm add https://pkg.pr.new/novuhq/novu/@novu/notification-center@6900

novu

pnpm add https://pkg.pr.new/novuhq/novu@6900

@novu/providers

pnpm add https://pkg.pr.new/novuhq/novu/@novu/providers@6900

@novu/react

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react@6900

@novu/react-native

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react-native@6900

@novu/shared

pnpm add https://pkg.pr.new/novuhq/novu/@novu/shared@6900

@novu/stateless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/stateless@6900

commit: 71d0703

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 71d0703
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/672df90b2fa67c0008787152
😎 Deploy Preview https://deploy-preview-6900--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BiswaViraj BiswaViraj force-pushed the nv-4516-in-app-step-editor-custom-step-controls-form branch from 99e8b1b to 71d0703 Compare November 8, 2024 11:42
@BiswaViraj BiswaViraj merged commit c510ac5 into next Nov 8, 2024
31 of 34 checks passed
@BiswaViraj BiswaViraj deleted the nv-4516-in-app-step-editor-custom-step-controls-form branch November 8, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants