feat(dashboard,web): opt-in welcome modal #6920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
approved these changes
Nov 11, 2024
ChmaraX
commented
Nov 11, 2024
| @@ -20,7 +20,7 @@ const DialogOverlay = React.forwardRef< | |||
| <DialogPrimitive.Overlay | |||
| ref={ref} | |||
| className={cn( | |||
| 'data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 fixed inset-0 z-50 bg-black/80', | |||
| 'data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 fixed inset-0 z-50 bg-black/10', | |||
There was a problem hiding this comment.
the backdrop when modal was open was too dark
ChmaraX
commented
Nov 11, 2024
| @@ -37,7 +37,8 @@ const DialogContent = React.forwardRef< | |||
| <DialogPrimitive.Content | |||
| ref={ref} | |||
| className={cn( | |||
| 'bg-background data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[state=closed]:slide-out-to-left-1/2 data-[state=closed]:slide-out-to-top-[48%] data-[state=open]:slide-in-from-left-1/2 data-[state=open]:slide-in-from-top-[48%] fixed left-[50%] top-[50%] z-50 grid w-full max-w-lg translate-x-[-50%] translate-y-[-50%] gap-5 border p-5 shadow duration-200 sm:rounded-lg', | |||
| 'bg-background data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[state=closed]:slide-out-to-left-1/2 data-[state=closed]:slide-out-to-top-[48%] data-[state=open]:slide-in-from-left-1/2 data-[state=open]:slide-in-from-top-[48%] fixed left-[50%] top-[50%] z-50 grid w-auto min-w-[320px] translate-x-[-50%] translate-y-[-50%] gap-5 border p-5 shadow duration-200 sm:rounded-lg', | |||
There was a problem hiding this comment.
Change so the modal will take width of its content + min width
ChmaraX
commented
Nov 11, 2024
| import { useUser } from '@clerk/clerk-react'; | ||
| import { NewDashboardOptInStatusEnum } from '@novu/shared'; | ||
|
|
||
| export function useNewDashboardOptIn() { |
There was a problem hiding this comment.
1:1 hook as useNewDashboardOptIn in web. Not sure if putting this to shared would be good idea since it depends on @clerk package and we haven't stored hooks in shared yet
@novu/client
@novu/js
@novu/headless
@novu/nest
@novu/nextjs
@novu/node
@novu/framework
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
@novu/stateless
commit: |
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?