refactor(shared, dal, application-generic, api, web, dashboard): Remove json-schema-to-ts dependency and use JsonSchemaDto everywhere
#6921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rifont
commented
Nov 11, 2024
| type?: JSONSchemaTypeName | JSONSchemaTypeName[] | undefined; | ||
| enum?: JSONSchemaType[] | undefined; | ||
| const?: JSONSchemaType | undefined; | ||
| export type JSONSchemaDto = Readonly<{ |
There was a problem hiding this comment.
These changes are for compatibility with json-schema-to-ts's declaration of Json Schema 7 typings.
rifont
changed the title
json-schema-to-ts dependency and use JsonSchemaDto everywherejson-schema-to-ts dependency and use JsonSchemaDto everywhere
@novu/client
@novu/framework
@novu/js
@novu/headless
@novu/nest
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
@novu/stateless
commit: |
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rifont
commented
Nov 11, 2024
| @@ -1,7 +1,7 @@ | |||
| import type { JSONSchema, FromSchema as JsonSchemaInfer } from 'json-schema-to-ts'; | |||
| import zod from 'zod'; | |||
|
|
|||
| export type JsonSchema = JSONSchema; | |||
| export type JsonSchema = Exclude<JSONSchema, boolean>; | |||
There was a problem hiding this comment.
The JSON schema used in Framework is a root-level JSON schema, which can't be a boolean. For completeness, the boolean value in the library package is present to allow for additionalProperties: JSONSchema | boolean, which is a valid JSON schema polymorphism.
rifont
commented
Nov 11, 2024
Comment on lines
-41
to
-43
| "@types/bluebird": "^3.5.24", | ||
| "@types/jest": "29.5.2", | ||
| "json-schema-to-ts": "^3.0.0", |
…ovu into jsonschema-dto-everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
json-schema-to-tsdependency and use@novu/shared'sJsonSchemaDtoeverywhereScreenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer