feat(dashboard): unify success toasts #6937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rifont
reviewed
Nov 11, 2024
apps/dashboard/src/components/workflow-editor/test-workflow/test-workflow-tabs.tsx
Outdated
Show resolved
Hide resolved
rifont
reviewed
Nov 11, 2024
rifont
reviewed
Nov 11, 2024
Comment on lines
+67
to
+77
| <SuccessButtonToast | ||
| title={`Workflow synced to ${environment?.name}`} | ||
| description={`Workflow '${workflow.name}' has been successfully synced to ${environment?.name}.`} | ||
| actionLabel={`Switch to ${environment?.name}`} | ||
| onAction={() => { | ||
| close(); | ||
| switchEnvironment(environment?.slug || ''); | ||
| }} | ||
| onClose={close} | ||
| /> | ||
| ), |
There was a problem hiding this comment.
❓ question: The environment should be defined at this point. If it's easy to do so, can we fix the types or return a loading state whilst it's not defined?
There was a problem hiding this comment.
This is an issue across the new Dashboard as the returned type of environment from the useEnvironment hook. We can use discriminated unions to make sure the environment is not optional if a loaded: true flag is true or we can use an env guard that ensures all its children have an environment set.
I suggest we tackled this in a separate PR across all the codebase.
SokratisVidros
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Before:
Now: