feat(api): add delay digest ui schemas #7032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
commented
Nov 17, 2024
Comment on lines
+17
to
+21
| uiSchema: inAppUiSchema, | ||
| }, | ||
| [ChannelStepEnum.EMAIL]: { | ||
| schema: EmailStepControlSchema, | ||
| uiSchema: EmailStepUiSchema, | ||
| schema: emailStepControlSchema, | ||
| uiSchema: emailStepUiSchema, |
There was a problem hiding this comment.
update naming conventions
djabarovgeorge
commented
Nov 17, 2024
There was a problem hiding this comment.
update naming conventions, and remove comments that do not add new info.
djabarovgeorge
commented
Nov 17, 2024
apps/api/src/app/workflows-v2/usecases/patch-step-data/patch-step.usecase.ts
Outdated
Show resolved
Hide resolved
djabarovgeorge
commented
Nov 17, 2024
Comment on lines
34
to
36
| private patchWorkflowFields(persistedWorkflow, command: PatchWorkflowCommand): NotificationTemplateEntity { | ||
| const transientWorkflow: NotificationTemplateEntity = { ...persistedWorkflow }; | ||
| if (command.active !== undefined && command.active !== null) { |
There was a problem hiding this comment.
not relevant to this pr:
make sure we check for nulls as well, and type correction.
There was a problem hiding this comment.
need to revert null check change, because it is incorrect due to the new FE-BE communication design decision from Friday.
djabarovgeorge
commented
Nov 17, 2024
Comment on lines
157
to
161
| /** | ||
| * Upsert workflow preferences. While this operation is not typically needed | ||
| * in a standard workflow update, it's maintained here to support environment | ||
| * sync scenarios and to enable code reusability. | ||
| */ |
There was a problem hiding this comment.
not relevant to this pr:
that is a good comment to have, as it is not straightforward logic.
There was a problem hiding this comment.
I think I conflicted with this - we should be able to remove this comment as Workflow Pref mutations are now handled in {Create,Update}Workflow use-cases now, and I have commented similarly.
There was a problem hiding this comment.
Conflicts are not a new thing for me ;)
No Problem if we have it on update/create i will remove this one.
djabarovgeorge
commented
Nov 17, 2024
Comment on lines
+32
to
+38
| DIGEST_AMOUNT = 'DIGEST_AMOUNT', | ||
| DIGEST_UNIT = 'DIGEST_UNIT', | ||
| DIGEST_KEY = 'DIGEST_KEY', | ||
| DIGEST_CRON = 'DIGEST_CRON', | ||
| DELAY_TYPE = 'DELAY_TYPE', | ||
| DELAY_AMOUNT = 'DELAY_AMOUNT', | ||
| DELAY_UNIT = 'DELAY_UNIT', |
There was a problem hiding this comment.
figma was not loading for me, for now, i created a dedicated value for each component.
rifont
reviewed
Nov 17, 2024
apps/api/src/app/workflows-v2/usecases/patch-workflow/patch-workflow.usecase.ts
Show resolved
Hide resolved
…chemas # Conflicts: # apps/api/src/app/workflows-v2/shared/schemas/in-app-control.schema.ts # apps/api/src/app/workflows-v2/usecases/patch-workflow/patch-workflow.usecase.ts # apps/api/src/app/workflows-v2/usecases/upsert-workflow/upsert-workflow.usecase.ts
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
tatarco
approved these changes
Nov 19, 2024
@novu/client
@novu/framework
@novu/js
@novu/headless
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
https://linear.app/novu/issue/NV-4735/delay-step-create-the-uischema
https://linear.app/novu/issue/NV-4738/digest-step-create-the-uischema
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer