fix(api): Resolve circular import issue for workflow update validation #7151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rifont
reviewed
Nov 28, 2024
| NotificationStep, | ||
| } from '../..'; | ||
| } from './upsert-validation-constants'; | ||
| import { ContentIssue, IStepControl, NotificationStep } from '../..'; |
There was a problem hiding this comment.
These import statements from index files ('../..' ) are usually the problematic ones for creating circular import dependencies. I think changing the line above to include an absolute path reference will be all that's required here.
That said, having the validation constants in a separate file is much cleaner.
There was a problem hiding this comment.
I pushed a fix for this so that we can merge it asap.
rifont
changed the title
…env variable (#7105) Co-authored-by: Dima Grossman <dima@grossman.io>
SokratisVidros
requested review from
SokratisVidros and
scopsy
and removed request for
a team
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
approved these changes
Nov 28, 2024
| NotificationStep, | ||
| } from '../..'; | ||
| } from './upsert-validation-constants'; | ||
| import { ContentIssue, IStepControl, NotificationStep } from '../..'; |
There was a problem hiding this comment.
I pushed a fix for this so that we can merge it asap.
@novu/client
@novu/framework
@novu/headless
@novu/js
@novu/nest
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
@novu/stateless
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
update call was not validating as expected
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer