style(dashboard): improve keys page design and look and feel #7236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scopsy
commented
Dec 8, 2024
Comment on lines
+17
to
+19
| 'bg-background flex h-12 w-full items-center justify-between border-b border-b-neutral-100 px-2.5 py-1.5', | ||
| className | ||
| )} |
There was a problem hiding this comment.
Fixed the color to match Figma designs of the bottom border
scopsy
commented
Dec 8, 2024
Comment on lines
+12
to
+16
| <div | ||
| ref={ref} | ||
| className={cn('flex flex-col space-y-1.5 bg-neutral-50 p-4 text-sm font-medium', className)} | ||
| {...props} | ||
| /> |
There was a problem hiding this comment.
Updated card bg to reflect design system
scopsy
commented
Dec 8, 2024
Comment on lines
+3
to
+5
| export const Container = ({ children, className }: { children: React.ReactNode; className?: string }) => { | ||
| return <div className={cn('mx-auto w-full max-w-[1152px] px-14 py-14', className)}>{children}</div>; | ||
| }; |
There was a problem hiding this comment.
Add a reusable container at 1152px width
There was a problem hiding this comment.
to me feels like to generic component with very specific CSS 😅
There was a problem hiding this comment.
The goal for this one is to be consistent across all pages that needs to use the container width. This is the first page to need it
scopsy
commented
Dec 8, 2024
Comment on lines
+11
to
+24
| export function HelpTooltipIndicator({ text, className, size = '5' }: HelpTooltipIndicatorProps) { | ||
| return ( | ||
| <Tooltip> | ||
| <TooltipTrigger asChild> | ||
| <span className={cn('text-foreground-400 hover:cursor inline-block', className)}> | ||
| <RiInformation2Line className={`size-${size}`} /> | ||
| </span> | ||
| </TooltipTrigger> | ||
| <TooltipContent> | ||
| <p>{text}</p> | ||
| </TooltipContent> | ||
| </Tooltip> | ||
| ); | ||
| } |
There was a problem hiding this comment.
This can be used to easily embed help tooltips
scopsy
changed the title
scopsy
changed the title
|
|
||
| const handleClick = () => { | ||
| telemetry(TelemetryEvent.EXTERNAL_LINK_CLICKED, { | ||
| href, |
Co-authored-by: George Djabarov <39195835+djabarovgeorge@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer