feat(dashboard): sms step #7316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ChmaraX
requested review from
LetItRock,
desiprisg,
SokratisVidros and
BiswaViraj
BiswaViraj
reviewed
Dec 17, 2024
Comment on lines
+4
to
+8
| <motion.div | ||
| initial={{ opacity: 0, y: 10 }} | ||
| animate={{ opacity: 1, y: 0 }} | ||
| transition={{ duration: 0.3, ease: 'easeOut' }} | ||
| className="relative my-1 inline-block max-w-[90%] rounded-2xl bg-[#e9ecef] px-4 py-2 text-sm text-[#2b2b33] before:absolute before:bottom-0 before:left-[-7px] before:h-5 before:w-5 before:rounded-br-[15px] before:bg-[#e9ecef] before:content-[''] after:absolute after:bottom-0 after:left-[-10px] after:h-5 after:w-[10px] after:rounded-br-[10px] after:bg-white after:content-['']" |
There was a problem hiding this comment.
nice addition of animation 🙌🏼
BiswaViraj
reviewed
Dec 18, 2024
apps/dashboard/src/components/workflow-editor/steps/sms/sms-editor-preview.tsx
Outdated
Show resolved
Hide resolved
BiswaViraj
reviewed
Dec 18, 2024
apps/dashboard/src/components/workflow-editor/steps/sms/sms-editor-preview.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Note: I omitted the
inline-tipscomponent from design since we don't have the primitive yet and it should be applied globally also for e.g. "action required" error link in step etc. Will be done separately in new PR.Adding new SMS step:
sms-1.mov
Error state / no preview available:
sms-2.mov
Long SMS body truncation:
sms-3.mov
Loading state:
sms-4.mov