feat(dashboard): Nv 4884 push mini preview #7318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance custom step controls
…ctionality and animations
…ison in configure step template form
…rols for improved layout
…nt value change handling
…ult functionality and documentation link
…nnecessary wrappers around custom step controls
…essary fragments in ConfigureStepForm
…rm for consistency
…ustomControlValues and update references
…override toggle UI
…roved UI structure in CustomStepControls
…ance custom step controls
…nnecessary wrappers around custom step controls
…elete functionality for control values
…d update related logic
… case in upsert workflow use case
…necessary checks and methods
…ance custom step controls
…or improved aesthetics
SokratisVidros
approved these changes
Dec 18, 2024
| ); | ||
| } | ||
|
|
||
| if (previewData?.result.type !== ChannelTypeEnum.PUSH) { |
There was a problem hiding this comment.
Don't we already have guarantees in parent components that this push-preview will only be rendered when the channel type is a PUSH?
If yes, we can remove this conditional.
There was a problem hiding this comment.
Yes, but this also helps TS narrowing the types
There was a problem hiding this comment.
hahaha Ok, not a good enough reason but not a blocker as well. If we change the preview DTO to a much flatter alternative it would be much easier for us to fix this issue.
ChmaraX
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Screen.Recording.2024-12-17.at.9.46.12.PM.mov
Expand for optional sections
Related enterprise PR
Special notes for your reviewer