fix(js): Inbox DX fixes #7396
Merged
fix(js): Inbox DX fixes #7396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
force-pushed
the
inbox_dx_fixes
branch
from
0e3b69a to
34f8dba
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
scopsy
reviewed
Dec 27, 2024
Comment on lines
+47
to
+49
| channels, | ||
| // @deprecated use channels instead | ||
| channelPreferences, |
There was a problem hiding this comment.
We are already doing a breaking change for the apiUrl, so I think we can just continue 😅 Just need to make sure to tell about this on release notes and changelog
There was a problem hiding this comment.
Oh nvm, just noticed it was on the httpclient only
There was a problem hiding this comment.
We are not doing a breaking change as we have deprecated the old backendUrl and introduced the apiUrl on the NovuOptions. Similarly, on the update preferences args.
scopsy
approved these changes
Dec 27, 2024
Comment on lines
+47
to
+49
| channels, | ||
| // @deprecated use channels instead | ||
| channelPreferences, |
There was a problem hiding this comment.
Oh nvm, just noticed it was on the httpclient only
It should be channels, not channelPreferences.
SokratisVidros
force-pushed
the
inbox_dx_fixes
branch
from
34f8dba to
c22f69e
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
@novu/js
@novu/nextjs
novu
@novu/react
@novu/react-native
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Update naming for improved DX. See commits for more details.