feat(dashboard): Make the whole workflow row clickable #7408
Conversation
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -160,47 +180,43 @@ export const WorkflowRow = ({ workflow }: WorkflowRowProps) => { | |||
| }; | |||
|
|
|||
| return ( | |||
| <TableRow key={workflow._id} className="relative"> | |||
| <TableRow key={workflow._id} className="group relative isolate"> | |||
There was a problem hiding this comment.
What if we just do:
<TableRow key={workflow._id} className="hover:bg-accent/50 relative hover:cursor-pointer" onClick={handleRowClick}>
On the main row, and add to the onHoverCopy and actions cell:
onClick={(e) => e.stopPropagation()}
Might simplify this a bit, wdyt?
There was a problem hiding this comment.
The implementation feels like an overkill, but if I am not mistaken, it's the only way to maintain valid Table/tr/td HTML while treating each row as a link, making right-clicking Open in a new Tab work.
@desiprisg Please confirm.
There was a problem hiding this comment.
Yes that's the thinking behind this. Also checked with some other implementations like stripe's and they seem to follow the same approach.
desiprisg
deleted the
nv-4810-ux-make-the-whole-workflow-list-clickable
branch
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer