Fixes for web #324
Merged
Fixes for web #324
+40
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now we default to not logging in on web but also fix social media login so we can test in logged in state.
kackogut
approved these changes
Sep 9, 2024
| if (kIsWeb) { | ||
| await _client.auth.signInWithOAuth( | ||
| OAuthProvider.google, | ||
| redirectTo: 'http://localhost:5000/', |
There was a problem hiding this comment.
Maybe extract the link to constants?
There was a problem hiding this comment.
Yeah this is all a bit of a hack at the moment to get web working. We will need to pull this from the environment once we actually start supporting web
There was a problem hiding this comment.
I promise to make this betterer in follow ups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we default to not logging in on web but also fix social media login so we can test in logged in state.
Description
Please include a brief summary of what the issue is and what has been done to solve it
Fixes #<issue_number> or taiga link
Checklist:
Creator
Reviewer
After pull